feat(linter/plugins): introduce RuleTester
#16206
Draft
+906
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-linter
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
overlookmotel
force-pushed
the
11-26-feat_linter_plugins_introduce_ruletester_
branch
from
87f7b96 to
0ef5845
Compare
overlookmotel
force-pushed
the
11-26-feat_linter_plugins_introduce_ruletester_
branch
from
0ef5845 to
7d01b65
Compare
overlookmotel
changed the base branch from
graphite-base/16206
to
11-27-refactor_linter_plugins_add_registerplugin_function
overlookmotel
force-pushed
the
11-26-feat_linter_plugins_introduce_ruletester_
branch
from
7d01b65 to
46826a5
Compare
overlookmotel
force-pushed
the
11-27-refactor_linter_plugins_add_registerplugin_function
branch
from
1302f61 to
afc5df6
Compare
overlookmotel
force-pushed
the
11-27-refactor_linter_plugins_add_registerplugin_function
branch
from
afc5df6 to
df85032
Compare
overlookmotel
force-pushed
the
11-26-feat_linter_plugins_introduce_ruletester_
branch
2 times, most recently
from
6ce2fd7 to
1baf878
Compare
overlookmotel
force-pushed
the
11-27-refactor_linter_plugins_add_registerplugin_function
branch
from
df85032 to
54de704
Compare
graphite-app
bot
force-pushed
the
11-27-refactor_linter_plugins_add_registerplugin_function
branch
2 times, most recently
from
be3b9ee to
832983a
Compare
graphite-app
bot
force-pushed
the
11-26-feat_linter_plugins_introduce_ruletester_
branch
from
1baf878 to
04e394c
Compare
overlookmotel
force-pushed
the
11-26-feat_linter_plugins_introduce_ruletester_
branch
3 times, most recently
from
b644de3 to
75f972d
Compare
overlookmotel
force-pushed
the
11-27-refactor_linter_plugins_add_registerplugin_function
branch
from
832983a to
b15c057
Compare
overlookmotel
changed the base branch from
11-27-refactor_linter_plugins_add_registerplugin_function
to
graphite-base/16206
overlookmotel
force-pushed
the
11-26-feat_linter_plugins_introduce_ruletester_
branch
from
75f972d to
f0fb3fb
Compare
overlookmotel
force-pushed
the
graphite-base/16206
branch
from
b15c057 to
d89782f
Compare
overlookmotel
changed the base branch from
graphite-base/16206
to
11-27-feat_linter_plugins_implement_options_merging
graphite-app bot
pushed a commit
that referenced
this pull request
Nov 27, 2025
Pure refactor. Move a few lines of code into `loadPlugin`, to leave a sync function `registerPlugin` which contains the logic for registering a plugin. Required for #16206, which will call this method directly, skipping `import`-ing the plugin from a module.
graphite-app
bot
changed the base branch from
11-27-feat_linter_plugins_implement_options_merging
to
graphite-base/16206
graphite-app bot
pushed a commit
that referenced
this pull request
Nov 27, 2025
Implement function for merging rule options from config with the rule's default options. This function is not currently used, as we don't have a way to get options from config over from Rust to JS yet, but I've implemented it now, as it's also needed for the rule tester (#16206).
graphite-app
bot
force-pushed
the
graphite-base/16206
branch
from
d89782f to
8881d7f
Compare
graphite-app
bot
force-pushed
the
11-26-feat_linter_plugins_introduce_ruletester_
branch
from
f0fb3fb to
350bad0
Compare
graphite-app
bot
force-pushed
the
11-26-feat_linter_plugins_introduce_ruletester_
branch
from
350bad0 to
37fd717
Compare
overlookmotel
force-pushed
the
11-26-feat_linter_plugins_introduce_ruletester_
branch
from
37fd717 to
b0622b5
Compare
overlookmotel
changed the base branch from
graphite-base/16206
to
11-27-fix_linter_plugins_deep_freeze_options
graphite-app
bot
changed the base branch from
11-27-fix_linter_plugins_deep_freeze_options
to
main
graphite-app
bot
force-pushed
the
11-26-feat_linter_plugins_introduce_ruletester_
branch
from
b0622b5 to
4ef629f
Compare
graphite-app
bot
force-pushed
the
11-26-feat_linter_plugins_introduce_ruletester_
branch
from
4ef629f to
0befe20
Compare
overlookmotel
force-pushed
the
11-26-feat_linter_plugins_introduce_ruletester_
branch
2 times, most recently
from
e94dc50 to
a3dfc5b
Compare
overlookmotel
force-pushed
the
11-26-feat_linter_plugins_introduce_ruletester_
branch
from
a3dfc5b to
550e974
Compare
overlookmotel
changed the base branch from
graphite-base/16206
to
11-28-refactor_linter_plugins_add_parse_function
overlookmotel
force-pushed
the
11-26-feat_linter_plugins_introduce_ruletester_
branch
from
550e974 to
81260a5
Compare
overlookmotel
force-pushed
the
11-28-refactor_linter_plugins_add_parse_function
branch
from
8df0e41 to
6f782ba
Compare
overlookmotel
force-pushed
the
11-26-feat_linter_plugins_introduce_ruletester_
branch
from
81260a5 to
0660dff
Compare
overlookmotel
force-pushed
the
11-28-refactor_linter_plugins_add_parse_function
branch
from
6f782ba to
b184e4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16018.
WIP